HonahX commented on code in PR #987:
URL: https://github.com/apache/polaris/pull/987#discussion_r1951839439
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java:
##########
@@ -157,6 +161,20 @@ static void setup(PolarisApiEndpoints apiEndpoints,
ClientCredentials credential
principalRoleName = client.newEntityName("rest-admin");
principalCredentials =
managementApi.createPrincipalWithRole(principalName, principalRoleName);
catalogApi = client.catalogApi(principalCredentials);
+ URI testRootUri =
+ Optional.ofNullable(System.getenv("INTEGRATION_TEST_TEMP_DIR"))
+ .map(URI::create)
+ .orElse(tempDir.toUri());
+ s3BucketBase =
+ Optional.ofNullable(System.getenv("INTEGRATION_TEST_S3_PATH"))
Review Comment:
Do we need to keep backward compatibility here? Is this environment variable
expected to be used in CI pipelines, or is it mainly for local debugging? If
it's mostly for local use, consolidating into a single variable might make
things simpler and help avoid confusion. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
