dennishuo commented on code in PR #988:
URL: https://github.com/apache/polaris/pull/988#discussion_r1951958363
##########
regtests/run.sh:
##########
@@ -52,7 +52,7 @@ cd ${REGTEST_HOME}
if [ -z "${1}" ]; then
loginfo 'Running all tests'
- TEST_LIST="$(find t_* -wholename '*t_*/src/*')"
+ TEST_LIST="client/python/test $(find t_* -wholename '*t_*/src/*')"
Review Comment:
Yeah, I also had to dig a bit to figure out what happened, since I do
remember those pytests successfully running back when I added `--set-property`,
etc.
@collado-mike mentioned he remembered someone fixed "duplicate pytests" in
run.sh recently, so we pieced it together.
Looks like your https://github.com/apache/polaris/pull/725/files fixed the
bug where we "accidentally" just run `python3 -m pytest` on the entire
`regtests` directory, and that was what accidentally gave coverage of the
client/python/test files in addition to duplicating things like `t_cli`. I also
never would have noticed that without digging in to look for it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
