collado-mike commented on code in PR #952:
URL: https://github.com/apache/polaris/pull/952#discussion_r1953455000
##########
service/common/src/main/java/org/apache/polaris/service/auth/JWTBroker.java:
##########
@@ -98,8 +98,12 @@ public String getScope() {
@Override
public TokenResponse generateFromToken(
- TokenType tokenType, String subjectToken, String grantType, String
scope) {
- if (!TokenType.ACCESS_TOKEN.equals(tokenType)) {
+ TokenType subjectTokenType,
+ String subjectToken,
+ String grantType,
+ String scope,
+ TokenType requestedTokenType) {
+ if (!TokenType.ACCESS_TOKEN.equals(subjectTokenType)) {
Review Comment:
@dimas-b I added this check. Can you approve again? 🤪
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
