jbonofre commented on PR #886: URL: https://github.com/apache/polaris/pull/886#issuecomment-2663778798
Quick sum-up on this one: - `PolarisManagementServiceIntegrationTest` does assertions on REST response like response body should not contain `foobar must not be null` - if the machine locale where the test is executed is not `en_US`, then the build is failing as the assertion is not valid: if the default locale is `fr_FR`, the REST response will be `foobar ne doit pas être null` instead of `foobar must not be null`. This is the same if the locale is not `en`. - In this PR, I propose to just force the locale for the tests in the quarkus app My intention is: 1. just to fix the test for contributors using another locale. It's possible to "square" to the specific `PolarisManagementServiceIntegrationTest`. 2. not to introduce any complex i18n or similar thing (that should be discussed (does it make sense yes or no)). 3. if you think 1 is not a good idea, another approach would be to clear document what's needed to have the int tests passing (like set your locale to `en`, with something like `export LC_ALL=en_US` @gh-yzou @adutra @dimas-b @flyrain @snazy just to provide a kind of sum-up. Happy to update this PR with your advices. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
