dennishuo commented on code in PR #1026:
URL: https://github.com/apache/polaris/pull/1026#discussion_r1964490248
##########
spec/polaris-management-service.yml:
##########
@@ -850,9 +850,92 @@ components:
- $ref: "#/components/schemas/Catalog"
- type: object
properties:
- remoteUrl:
- type: string
- description: URL to the remote catalog API
+ connectionConfigInfo:
+ $ref: "#/components/schemas/ConnectionConfigInfo"
Review Comment:
For current backwards-compatibility, I was actually thinking of it like:
1. if (ExternalCatalog.getConnectionConfigInfo() == null) { internalSubtype
= STATIC_FACADE; }
2. else { internalSubtype = PASSTHROUGH_FACADE; }
Admittedly that might be kind of a hack to only use the presence of
connection config to determine static vs passthrough facade, but conceptually,
it makes sense that an ExternalCatalog that can't dial out to a remote catalog
fundamentally must behave as a "static facade" where content is "pushed" into
the ExternalCatalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
