mansehajsingh commented on code in PR #1037:
URL: https://github.com/apache/polaris/pull/1037#discussion_r1974203957
##########
service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:
##########
@@ -571,10 +573,17 @@ public ListTablesResponse listTables(Namespace namespace)
{
return doCatalogOperation(() -> CatalogHandlers.listTables(baseCatalog,
namespace));
}
- public LoadTableResponse createTableDirect(Namespace namespace,
CreateTableRequest request) {
+ /**
+ * Create a table.
+ * @param namespace the namespace to create the table in
+ * @param request the table creation request
+ * @return ETagged {@link LoadTableResponse} to uniquely identify the table
metadata
+ */
+ public ETaggedResponse<LoadTableResponse> createTableDirect(Namespace
namespace, CreateTableRequest request) {
Review Comment:
Sorry, I'm having trouble catching- Are you proposing that we give both a
createTable with etag and one without? There is an etag on creation so we
return it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
