dimas-b commented on code in PR #1092:
URL: https://github.com/apache/polaris/pull/1092#discussion_r1977931544
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##########
@@ -205,7 +209,11 @@ public void runActionInTransaction(
}
} catch (Exception e) {
LOGGER.debug("Rolling back transaction due to an error", e);
- tr.rollback();
+ // For some transaction conflict errors, the transaction will already
no longer be active;
+ // if it's still active, explicitly rollback.
+ if (tr.isActive()) {
Review Comment:
Good point. I guess that might be the reason for 500 errors in my old test
with Serializable isolation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
