eric-maynard commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r1978024470
########## quarkus/defaults/src/main/resources/application.properties: ########## @@ -94,6 +94,8 @@ polaris.persistence.type=in-memory polaris.file-io.type=default +polaris.events.type=default Review Comment: Can this just be like `polaris.events.listener`? ########## service/common/src/main/java/org/apache/polaris/service/events/BeforeTableRefreshEvent.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.events; + +import org.apache.iceberg.catalog.TableIdentifier; + +/** + * Emitted when Polaris intends to refresh its known version of a table's metadata by fetching the + * latest. + * + * @param tableIdentifier The identifier of the table being refreshed. + */ +public record BeforeTableRefreshEvent(TableIdentifier tableIdentifier) {} Review Comment: The events don't have a shared parent type? ########## quarkus/service/src/main/java/org/apache/polaris/service/quarkus/events/QuarkusPolarisEventListenerConfiguration.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.quarkus.events; + +import io.quarkus.runtime.annotations.StaticInitSafe; +import io.smallrye.config.ConfigMapping; + +@StaticInitSafe +@ConfigMapping(prefix = "polaris.events") +public interface QuarkusPolarisEventListenerConfiguration { + /** + * The type of the event listener to use. Must be a registered {@link + * org.apache.polaris.service.events.PolarisEventListener} identifier. + */ + String type(); Review Comment: `type` is a name we should perhaps avoid -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
