dimas-b commented on code in PR #1132:
URL: https://github.com/apache/polaris/pull/1132#discussion_r1985831034
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -376,4 +376,14 @@ ResolvedEntityResult refreshResolvedEntity(
@Nonnull PolarisEntityType entityType,
long entityCatalogId,
long entityId);
+
+ /**
+ * Indicates whether this metastore manager implementation requires entities
to be reloaded via
+ * {@link #loadEntitiesChangeTracking} in order to ensure the most recent
versions are obtained.
+ *
+ * <p>Generally this flag is {@code true} when entity caching is used.
+ */
+ default boolean requiresEntityReload() {
+ return true;
+ }
Review Comment:
That's what it looks like to me too, but I'd like to allow implementations
to make this decision separately. We can revisit and remove this method when a
NoSQL impl. is make available for review (if it happens to be redundat)... but
so far it seems useful for our WIP code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
