eric-maynard commented on code in PR #1068:
URL: https://github.com/apache/polaris/pull/1068#discussion_r1990205673
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfigurationStore.java:
##########
@@ -117,4 +122,16 @@ public interface PolarisConfigurationStore {
return getConfiguration(ctx, config);
}
}
+
+ public static <T> @Nonnull T getConfiguration(PolarisConfiguration<T>
configuration) {
+ CallContext callContext = CallContext.getCurrentContext();
+ if (callContext == null) {
+ return configuration.defaultValue;
Review Comment:
> the admin user changed the config.
From what I understand, the admin user can't do this in a situation where
there is no callcontext. If there is no callcontext, this config check is not
actually happening in the context of a call (ha) against a real service. It's
only tests. If you want, I can go into those tests and try to wire up a
CallContext threadlocal everywhere. I was approaching the problem with the
mentality that we will try to remove that threadlocal soon anyway and this
problem (and indeed this null-check) can go away soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
