HonahX commented on code in PR #1150:
URL: https://github.com/apache/polaris/pull/1150#discussion_r1992383764
##########
spec/polaris-catalog-service.yaml:
##########
@@ -127,13 +127,21 @@ paths:
# /v1/{prefix}/namespaces/{namespace}/tables/{table}/tasks:
# Not implemented in Polaris
- ######################
- # Polaris-native API #
- ######################
+ ############################
+ # Polaris Notification API #
+ ############################
/v1/{prefix}/namespaces/{namespace}/tables/{table}/notifications:
$ref:
'./polaris-catalog-apis/notifications-api.yaml#/paths/~1v1~1{prefix}~1namespaces~1{namespace}~1tables~1{table}~1notifications'
+ #############################
+ # Polaris Generic Table API #
+ #############################
+ /polaris/v1/{prefix}/namespaces/{namespace}/generic-tables:
+ $ref:
'./polaris-catalog-apis/generic-tables-api.yaml#/paths/~1polaris~1v1~1{prefix}~1namespaces~1{namespace}~1generic-tables'
+
+ /polaris/v1/{prefix}/namespaces/{namespace}/generic-tables/{generic-table}:
+ $ref:
'./polaris-catalog-apis/generic-tables-api.yaml#/paths/~1polaris~1v1~1{prefix}~1namespaces~1{namespace}~1generic-tables~1{generic-table}'
Review Comment:
Thanks @gh-yzou for summarizing. We can always re-organize these spec
definitions if needed without affecting the implementaion. The current way
allow us to share common open api definitions (servers, security scheme
definition), and we can still generate models and services in separate module,
like how they are generated in this PR. But let's discuss this in a separate
thread to decide whether we want to separate them into completely different
files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
