eric-maynard commented on code in PR #1170:
URL: https://github.com/apache/polaris/pull/1170#discussion_r1994687868


##########
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java:
##########
@@ -37,6 +37,7 @@ protected BehaviorChangeConfiguration(
     super(key, description, defaultValue, catalogConfig);
   }
 
+  @BehaviorChangeConfigurationSince("1.0.0")
   public static final BehaviorChangeConfiguration<Boolean> 
VALIDATE_VIEW_LOCATION_OVERLAP =

Review Comment:
   Ah, got it. Yeah so we would actually not stop enforcing it in 1.2.0, we 
would rip out the option to _not_ enforce the overlap in 1.2.0 if we haven't 
found justification to change the behavior by that time.



##########
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java:
##########
@@ -37,6 +37,7 @@ protected BehaviorChangeConfiguration(
     super(key, description, defaultValue, catalogConfig);
   }
 
+  @BehaviorChangeConfigurationSince("1.0.0")
   public static final BehaviorChangeConfiguration<Boolean> 
VALIDATE_VIEW_LOCATION_OVERLAP =

Review Comment:
   Ah, got it. Yeah so we would actually not stop enforcing it in 1.2.0, we 
would keep enforcing it. We would rip out the option to _not_ enforce the 
overlap in 1.2.0 if we haven't found justification to change the behavior by 
that time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to