eric-maynard commented on code in PR #1171:
URL: https://github.com/apache/polaris/pull/1171#discussion_r1996045373
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisGrantManager.java:
##########
@@ -119,23 +118,8 @@ PrivilegeResult revokePrivilegeOnSecurableFromRole(
* ENTITY_NOT_FOUND if the securable cannot be found
*/
@Nonnull
- default LoadGrantsResult loadGrantsOnSecurable(
- @Nonnull PolarisCallContext callCtx, PolarisBaseEntity securable) {
- return loadGrantsOnSecurable(callCtx, securable.getCatalogId(),
securable.getId());
- }
-
- /**
- * This method should be used by the Polaris app to cache all grant records
on a securable.
- *
- * @param callCtx call context
- * @param securableCatalogId id of the catalog this securable belongs to
- * @param securableId id of the securable
- * @return the list of grants and the version of the grant records. We will
return
- * ENTITY_NOT_FOUND if the securable cannot be found
- */
Review Comment:
Oh I see, the doc itself was removed. Can we re-introduce a javadoc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
