singhpk234 commented on code in PR #1133: URL: https://github.com/apache/polaris/pull/1133#discussion_r1996049960
########## polaris-core/src/main/java/org/apache/polaris/core/policy/PolicyType.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.policy; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonValue; +import jakarta.annotation.Nullable; + +/** + * Represents a policy type in Polaris. A policy type defines a category of policies that may be + * either predefined or custom (user-defined). + * + * <p>A policy type can be either inheritable or non-inheritable. Inheritable policies are passed + * down to lower-level entities (e.g., from a namespace to a table). Review Comment: > Currently, our engine determines how policies are enforced, and the TMS service is focused solely on tables Thats true for enforcing part, but polaris here is acting as a policy store, which should make sure if such inheritence if they are un-intentional are blocked. So a call to get a TMS policy on view should return nothing. That being said it fine if we want address this later, considering presently the caller just wants TMS on tables and never on a view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
