snazy commented on PR #808: URL: https://github.com/apache/polaris/pull/808#issuecomment-2724168104
@flyrain looks like you oversaw my strong concern `This change modifies Iceberg's REST API and adds Polaris specifics to it. Nothing guarantees that this "patch" on top of Iceberg's REST API won't break with an evolution of Iceberg's REST API.` - this has *not* been addressed - neither in this PR nor in #1150. To be clear: my [request for changes still stands](https://www.apache.org/foundation/voting.html#votes-on-code-modification)! So I ask you to revert this change! Related to the [discussion on the dev-ML](https://lists.apache.org/thread/xm8f7ojoh6v5nqlpg9o82k1oo3wd8zg4): Concerns about changing and/or depending on the Iceberg REST spec have been raised multiple times on PRs and on the dev-mailing-list. This PR introduces a hard dependency on the Iceberg REST spec. The approach take in this PR and #1150 should have discussed _explicitly_ on the dev mailing list, as stated in the project's [contributing guidelines](https://polaris.apache.org/community/contributing-guidelines/), which explicitly say: "Change of public interface (or more generally speaking Polaris extension point) should be discussed and approved on the dev mailing list. The discussion on the dev mailing list should happen before having a “ready-for-review” Pull Request." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
