snazy commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r1999373660
########## gradle.properties: ########## @@ -28,3 +28,5 @@ org.gradle.configuration-cache=false #org.gradle.configuration-cache-problems=warn # bump the Gradle daemon heap size (you can set bigger heap sizes as well) org.gradle.jvmargs=-Xms2g -Xmx4g -XX:MaxMetaspaceSize=768m +# default scala version used for spark plugin build +systemProp.defaultScalaVersion=2.12 Review Comment: This introduces manual build steps + complicates releases and CI quite a lot. It should leverage Gradle's ability to build against multiple Scala versions. Please borrow the build-logic code from Nessie to provide support for multiple Scala versions. ########## plugins/spark/build.gradle.kts: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar + +plugins { + id("polaris-client") + alias(libs.plugins.jandex) +} + +val sparkMajorVersion = "3.5" +val scalaVersion = + if (System.getProperty("scalaVersion") != null) { Review Comment: Using system properties in this way complicates the build, CI and releases quite a bit. You can take a flexible approach from Nessie's build that does not require this at all. ########## gradle/libs.versions.toml: ########## @@ -27,6 +27,7 @@ scala212 = "2.12.19" spark35 = "3.5.5" slf4j = "2.0.17" swagger = "1.6.15" +icebergspark = "1.8.0" Review Comment: We should not have two different Iceberg versions in Polaris. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
