andrew4699 commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2001532609
########## service/common/src/main/java/org/apache/polaris/service/events/AfterTaskAttemptedEvent.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.events; + +import org.apache.polaris.core.context.CallContext; + +/** + * Emitted after an attempt of an async task, such as manifest file cleanup, finishes. + * + * @param taskEntityId The ID of the TaskEntity. + * @param callContext The CallContext the task is being executed under. + * @param attempt The attempt number. Each retry of the task will have its own attempt number. The + * initial (non-retried) attempt starts counting from 1. + * @param success Whether or not the attempt succeeded. + */ +public record AfterTaskAttemptedEvent( + long taskEntityId, CallContext callContext, int attempt, boolean success) Review Comment: Can you elaborate on the attempt being wrong? I don't see what you're referring to. Here are some threads talking about use cases: - https://github.com/apache/polaris/pull/922#discussion_r1985539915 - https://github.com/apache/polaris/pull/922#discussion_r1984465794 Also the [design doc](https://docs.google.com/document/d/1sJiFKeMlPVlqRUj8Rv4YufMMrfCq_3ZFtDuNv_8eOQ0/edit?pli=1&tab=t.0#heading=h.8d519gwzsle2) talks about events specifically being intended to be super flexible because different Polaris users will have different needs. Not all events will be useful for everyone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
