gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2002208249
########## plugins/spark/build.gradle.kts: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar + +plugins { + id("polaris-client") + alias(libs.plugins.jandex) +} + +val sparkMajorVersion = "3.5" +val scalaVersion = + if (System.getProperty("scalaVersion") != null) { Review Comment: Actually, after looking at the ci test setup, I actually think the current setup make more sense. For spark client tests, the test setup could be very different compare with polaris server side, for example, the jvm for spark could be very different compare with Polaris. So a different ci definition is required for the client test, and using matrix for different test setup also makes thing fairly straightforward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
