gh-yzou commented on code in PR #1147:
URL: https://github.com/apache/polaris/pull/1147#discussion_r2002279058
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java:
##########
@@ -41,22 +41,22 @@ public enum PolarisPrivilege {
TABLE_CREATE(6, PolarisEntityType.NAMESPACE),
VIEW_CREATE(7, PolarisEntityType.NAMESPACE),
NAMESPACE_DROP(8, PolarisEntityType.NAMESPACE),
- TABLE_DROP(9, PolarisEntityType.TABLE_LIKE, PolarisEntitySubType.TABLE),
- VIEW_DROP(10, PolarisEntityType.TABLE_LIKE, PolarisEntitySubType.VIEW),
+ TABLE_DROP(9, PolarisEntityType.ICEBERG_TABLE_LIKE,
PolarisEntitySubType.TABLE),
Review Comment:
@snazy I don't think this PR currently does setup for GENERIC_TABLE
privilege yet, and the change in this file is just a renaming to me.
And you are right, the DROP_TABLE and DROP_VIEW privilege is only setup for
Iceberg table and View now. The generic tables are tables, not view, and
during the design, we mentioned that we will reuse the *_TABLE privilege since
they are all tables, and having DROP_TABLE and DROP_GENERIC_TABLE privilege
seems awkward to users. If we need more fine grained control in the future, it
make more sense to introduce privileges like DORP_ICEBERG_TABLE,
DROP_GENERIC_TABLE.
There is definitely changes needed to set up the privilege correctly, but i
don't think that is the purpose of the current PR. The current PR are mainly
doing refactor/rename, and with some basic class setup to demo the purpose of
rename/refactor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
