MonkeyCanCode commented on code in PR #1172:
URL: https://github.com/apache/polaris/pull/1172#discussion_r2002331934
##########
regtests/pyspark-setup.sh:
##########
@@ -18,14 +18,14 @@
# under the License.
#
-if [ ! -d ~/polaris-venv ]; then
- python3 -m venv ~/polaris-venv
+if [ ! -d ~/polaris/polaris-venv ]; then
Review Comment:
Assuming the path change is intensional?
##########
regtests/Dockerfile:
##########
@@ -35,24 +35,24 @@ USER spark
ENV
PYTHONPATH="${SPARK_HOME}/python/:${SPARK_HOME}/python/lib/py4j-0.10.9.7-src.zip:$PYTHONPATH"
# Copy and run setup.sh separately so that test sources can change, but the
setup script run is still cached
-WORKDIR /home/spark/regtests
-COPY ./setup.sh /home/spark/regtests/setup.sh
-COPY ./pyspark-setup.sh /home/spark/regtests/pyspark-setup.sh
-COPY ./client/python /home/spark/regtests/client/python
-COPY ./polaris-reg-test /home/spark/polaris
-COPY ./requirements.txt /tmp/
-
-RUN python3 -m venv /home/spark/polaris-venv && \
- . /home/spark/polaris-venv/bin/activate && \
+WORKDIR /home/spark/polaris
+COPY ./regtests/setup.sh /home/spark/polaris/regtests/setup.sh
+COPY ./regtests/pyspark-setup.sh /home/spark/polaris/regtests/pyspark-setup.sh
+COPY ./client/python /home/spark/polaris/client/python
+COPY ./regtests/polaris-reg-test /home/spark/polaris/polaris
Review Comment:
NIT: not a blocker for this, as now we have same layout for the dockerfile
used for testing, we should be able to retire `polaris-reg-test`. We can do it
in a later PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
