andrew4699 commented on code in PR #922:
URL: https://github.com/apache/polaris/pull/922#discussion_r2003882165
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1229,11 +1243,14 @@ public void doRefresh() {
Set.of(PolarisStorageActions.READ));
return TableMetadataParser.read(fileIO, metadataLocation);
});
+ polarisEventListener.onAfterTableRefreshed(new
AfterTableRefreshedEvent(tableIdentifier));
Review Comment:
> so lets implement a big chunk of them
Replace "them" with "events with demonstrable use cases".
> I'm asking for concrete requirements.
Ok, I've added a new column to the design doc with requirements/example use
cases for each event.
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1229,11 +1243,14 @@ public void doRefresh() {
Set.of(PolarisStorageActions.READ));
return TableMetadataParser.read(fileIO, metadataLocation);
});
+ polarisEventListener.onAfterTableRefreshed(new
AfterTableRefreshedEvent(tableIdentifier));
Review Comment:
> so lets implement a big chunk of them
Replace "them" with "events with demonstrable use cases".
> I'm asking for concrete requirements.
Ok, I've added a new column to the design doc with example use cases for
each event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
