snazy commented on code in PR #1237:
URL: https://github.com/apache/polaris/pull/1237#discussion_r2008776335
##########
client/python/cli/polaris_cli.py:
##########
@@ -118,7 +118,7 @@ def _get_client_builder(options):
# Validates
has_access_token = options.access_token is not None
has_client_secret = client_id is not None and client_secret is not None
- if has_access_token and has_client_secret:
+ if has_access_token and (options.client_id or options.client_secret):
Review Comment:
I don't think that the tool should magically prefer the access-token even if
client-id/secret are _explicitly_ specified. That's clearly an ambiguity.
The logic here is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
