dimas-b commented on code in PR #1126:
URL: https://github.com/apache/polaris/pull/1126#discussion_r2012290402
##########
regtests/t_pyspark/src/iceberg_spark.py:
##########
@@ -72,7 +72,7 @@ def __enter__(self):
"""Initial method for Iceberg Spark session. Creates a Spark session with
specified configs.
"""
packages = [
- "org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:1.7.1",
+ "org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:1.8.1",
Review Comment:
I believe it is important to test with older Iceberg clients too.
Ideally, regtests should run with current and previous versions. WDYT?
##########
gradle/libs.versions.toml:
##########
@@ -19,7 +19,7 @@
[versions]
hadoop = "3.4.1"
-iceberg = "1.7.1"
+iceberg = "1.8.1" # Ensure to update the iceberg version in regtests/setup.sh
to keep regtests up-to-date
Review Comment:
Technically, regtests can (and probably should) user different Iceberg
versions (on the client side) than what the server uses internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
