HonahX commented on code in PR #1104:
URL: https://github.com/apache/polaris/pull/1104#discussion_r2013359342
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##########
@@ -41,7 +42,7 @@
* the underlying data store. The goal is to make it really easy to back this
using databases like
* Postgres or simpler KV store.
*/
-public interface BasePersistence {
+public interface BasePersistence extends PolicyMappingPersistence {
Review Comment:
This is needed because `AtomicMetastoreManager` can only use methods in
BasePersistence. I think a better inheritance hierarchy is that we have an
`AtomicPersistence` interface that extends both BasePersistence and
PolicyMappingPersistence, and let `AtomicMetastoreManager` use methods in
`AtomicPersistence`. How about we do that in a follow-up to avoid too many
refactoring in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
