eric-maynard commented on code in PR #1262:
URL: https://github.com/apache/polaris/pull/1262#discussion_r2015788315
##########
regtests/t_pyspark/src/conftest.py:
##########
@@ -84,7 +84,8 @@ def aws_bucket_base_location_prefix():
"""
default_val = 'polaris_test'
bucket_prefix = os.getenv('AWS_BUCKET_BASE_LOCATION_PREFIX', default_val)
- return default_val if bucket_prefix == '' else bucket_prefix
+ # Add random string to prefix to prevent base location overlaps
+ return f"{default_val if bucket_prefix == '' else
bucket_prefix}_{str(uuid.uuid4())[-5:]}"
Review Comment:
ultra nit: Any reason to do `[-5:]` instead of the marginally more idiomatic
`[:5]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
