liamzwbao commented on code in PR #1126: URL: https://github.com/apache/polaris/pull/1126#discussion_r2020213830
########## quarkus/service/src/testFixtures/java/org/apache/polaris/service/quarkus/it/PolarisQuarkusTestBeforeClassCallback.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.quarkus.it; + +import io.quarkus.test.junit.callback.QuarkusTestBeforeClassCallback; +import org.assertj.core.api.Assumptions; +import org.assertj.core.configuration.PreferredAssumptionException; + +public class PolarisQuarkusTestBeforeClassCallback implements QuarkusTestBeforeClassCallback { + @Override + public void beforeClass(Class<?> testClass) { Review Comment: > Would it work if we excluded junit4 from the dependencies in Polaris? Actually it works, so I removed the callback and config the exclusion in the `polaris-quarkus-service` module. I didn’t apply this globally (like in banned-dependencies.txt) since it will cause other issues. Scoping the exclusion to just this module is sufficient for now. > Tests worked fine with Iceberg 1.7 apparently.... did Iceberg 1.8 bring new dependencies that cascade to juni4? I don’t think it's Iceberg 1.8 itself that brings new junit4 tests. Instead, the issue comes from tests inherited from Iceberg that now use AssertJ’s Assumptions. Previously, these tests only used junit5 Assumptions. The problem only occurs when all three are present: AssertJ, junit4 dependencies, and Quarkus. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
