pingtimeout commented on code in PR #2:
URL: https://github.com/apache/polaris-tools/pull/2#discussion_r2024258341
##########
benchmarks/build.gradle.kts:
##########
@@ -0,0 +1,29 @@
+plugins {
+ scala
+ id("io.gatling.gradle") version "3.13.5.2"
+ id("com.diffplug.spotless") version "7.0.2"
+}
+
+description = "Polaris Iceberg REST API performance tests"
+
+tasks.withType<ScalaCompile> {
+ scalaCompileOptions.forkOptions.apply {
+ jvmArgs = listOf("-Xss100m") // Scala compiler may require a larger
stack size when compiling Gatling simulations
+ }
+}
+
+dependencies {
+ gatling("com.typesafe.play:play-json_2.13:2.9.4")
Review Comment:
I believe this comment applies for the line just after `play-json` (the
`typesafe-config` line). Play-json is used to parse the payloads returned by
Polaris and ensure that maps (e.g. namespace properties) are equal. Given that
there is no order guarantee between properties, a plain string comparison
cannot be used. So play-json has to stay.
We _could_ move from typesafe-config to a `toml` file. But I would first
like to double check that we are talking about the same thing. Typesafe config
was initially preferred as it is already used to configure Gatling and offers
the ability to have default parameter values for benchmarks that can then be
overridden by users either from the CLI or a separate configuration (HOCON)
file.
AFAICT in #1, toml files are used for the Gradle build. The equivalent of
typesafe-config in #1 is picocli, not `toml` files. And I missing something
@ajantha-bhat?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
