dimas-b commented on code in PR #1289:
URL: https://github.com/apache/polaris/pull/1289#discussion_r2025418632
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -386,18 +386,27 @@ public Map<String, BaseResult>
purgeRealms(Iterable<String> realms) {
};
}
- /** TODO: Unblock this test, see:
https://github.com/apache/polaris/issues/1272 */
@Override
@Test
- @Disabled(
- """
- Disabled because the behavior is not applicable to Polaris.
- To unblock:
- 1) Align Polaris behavior with the superclass by handling empty
namespaces the same way, or
- 2) Modify this test to expect an exception and add a Polaris-specific
version.
- """)
public void listNamespacesWithEmptyNamespace() {
- super.listNamespacesWithEmptyNamespace();
+ // In Polaris, the empty namespace implicitly exists by default.
+ // The superclass test assumes the empty namespace does not exist
initially,
+ // so running it will fail as expected.
+ Assertions.assertThatThrownBy(super::listNamespacesWithEmptyNamespace)
+ .isInstanceOf(AssertionFailedError.class);
+ }
+
+ @Test
+ public void listNamespacesWithEmptyNamespaceInPolaris() {
+ catalog().createNamespace(NS);
+
+
Assertions.assertThat(catalog().namespaceExists(Namespace.empty())).isTrue();
+ Assertions.assertThat(catalog().listNamespaces())
+ .contains(NS)
+ .doesNotContain(Namespace.empty());
Review Comment:
This looks like a bug to me. The test clearly indicate that the empty
namespace exists, but is not returned when all namespaces are listed.
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -386,18 +386,27 @@ public Map<String, BaseResult>
purgeRealms(Iterable<String> realms) {
};
}
- /** TODO: Unblock this test, see:
https://github.com/apache/polaris/issues/1272 */
@Override
@Test
- @Disabled(
- """
- Disabled because the behavior is not applicable to Polaris.
- To unblock:
- 1) Align Polaris behavior with the superclass by handling empty
namespaces the same way, or
- 2) Modify this test to expect an exception and add a Polaris-specific
version.
- """)
public void listNamespacesWithEmptyNamespace() {
- super.listNamespacesWithEmptyNamespace();
+ // In Polaris, the empty namespace implicitly exists by default.
+ // The superclass test assumes the empty namespace does not exist
initially,
+ // so running it will fail as expected.
+ Assertions.assertThatThrownBy(super::listNamespacesWithEmptyNamespace)
+ .isInstanceOf(AssertionFailedError.class);
+ }
+
+ @Test
+ public void listNamespacesWithEmptyNamespaceInPolaris() {
+ catalog().createNamespace(NS);
+
+
Assertions.assertThat(catalog().namespaceExists(Namespace.empty())).isTrue();
+ Assertions.assertThat(catalog().listNamespaces())
+ .contains(NS)
+ .doesNotContain(Namespace.empty());
Review Comment:
This looks like a bug to me. The test clearly indicates that the empty
namespace exists, but is not returned when all namespaces are listed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
