gh-yzou commented on code in PR #1286: URL: https://github.com/apache/polaris/pull/1286#discussion_r2025352070
########## polaris-core/src/main/java/org/apache/polaris/core/rest/PolarisEndpoint.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.rest; + +import org.apache.iceberg.rest.Endpoint; + +public class PolarisEndpoint { Review Comment: i was originally trying to stay consistent as the iceberg class naming, where it call Endpoint.java. However, I don't think it is necessary after some thoughts, the Iceberg Endpoint class is really trying to define how an Endpoint will look like with HTTP method fields etc. My class here is really just a static class that defines a set of endpoints that is supported by Polaris. ``` are we going to add more endpoints in the future? e.g., policy, volume, and even endpoints in the management yaml? ``` for management endpoints, i am not sure. However, for new catalog endpoints supported, we should add the definition here and eventually add them to the getConfig as supported endpoints. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
