eric-maynard commented on code in PR #273:
URL: https://github.com/apache/polaris/pull/273#discussion_r2021932610
##########
service/common/build.gradle.kts:
##########
@@ -29,6 +29,7 @@ dependencies {
implementation(project(":polaris-api-management-service"))
implementation(project(":polaris-api-iceberg-service"))
implementation(project(":polaris-api-catalog-service"))
+ implementation(project(":polaris-jpa-model"))
Review Comment:
It's because `ModelEntity` is one of the types that
`EntityIdPageToken.updated` is intended to support. It allows the metastore
layer to update the existing page token with a `List<ModelEntity>`. If we can
remove this dependency I'm okay with it. To be honest, this looked very
different before the persistence refactor and this could be my misunderstanding
when resolving conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
