dimas-b commented on code in PR #1315:
URL: https://github.com/apache/polaris/pull/1315#discussion_r2029456531


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/CredentialVendorDao.java:
##########
@@ -16,17 +16,18 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.polaris.core.storage;
+package org.apache.polaris.core.persistence.dao;
 
 import jakarta.annotation.Nonnull;
 import java.util.Set;
 import org.apache.polaris.core.PolarisCallContext;
 import org.apache.polaris.core.entity.PolarisEntityType;
 import org.apache.polaris.core.persistence.dao.entity.ScopedCredentialsResult;
 import org.apache.polaris.core.persistence.dao.entity.ValidateAccessResult;
+import org.apache.polaris.core.storage.PolarisStorageActions;
 
 /** Manage credentials for storage locations. */
-public interface PolarisCredentialVendor {
+public interface CredentialVendorDao {

Review Comment:
   I'm not sure how to interpret this rename (and relocation to a different 
package).
   
   @flyrain : could you share an outline of the general ideas behind this 
refactoring on the dev ML? thx!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to