exceptionfactory commented on code in PR #1318:
URL: https://github.com/apache/polaris/pull/1318#discussion_r2031182512
##########
service/common/src/main/java/org/apache/polaris/service/auth/PemUtils.java:
##########
@@ -46,9 +45,38 @@ private static byte[] parsePEMFile(Path pemPath) throws
IOException {
throw new FileNotFoundException(
String.format("The file '%s' doesn't exist.",
pemPath.toAbsolutePath()));
}
- try (PemReader reader = new PemReader(Files.newBufferedReader(pemPath,
UTF_8))) {
- PemObject pemObject = reader.readPemObject();
Review Comment:
Thanks for the feedback and noting the behavior of `readPemObject()`. I
adjusted the new implementation to stop reading when finding a footer line, and
added unit tests for that scenario, as well as an empty file, which throws an
`IOException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
