flyrain commented on code in PR #1314:
URL: https://github.com/apache/polaris/pull/1314#discussion_r2031612460
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/PolicyCatalogTest.java:
##########
@@ -112,18 +122,26 @@ public Map<String, String> getConfigOverrides() {
}
}
- protected static final Namespace NS = Namespace.of("newdb");
- protected static final TableIdentifier TABLE = TableIdentifier.of(NS,
"table");
- public static final String CATALOG_NAME = "polaris-catalog";
- public static final String TEST_ACCESS_KEY = "test_access_key";
- public static final String SECRET_ACCESS_KEY = "secret_access_key";
- public static final String SESSION_TOKEN = "session_token";
-
- private static final Namespace NS1 = Namespace.of("ns1");
- private static final PolicyIdentifier POLICY1 = new PolicyIdentifier(NS1,
"p1");
- private static final PolicyIdentifier POLICY2 = new PolicyIdentifier(NS1,
"p2");
- private static final PolicyIdentifier POLICY3 = new PolicyIdentifier(NS1,
"p3");
- private static final PolicyIdentifier POLICY4 = new PolicyIdentifier(NS1,
"p4");
+ private static final Namespace NS = Namespace.of("ns1");
Review Comment:
They are useful, but only used within the current class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
