gh-yzou commented on code in PR #1303:
URL: https://github.com/apache/polaris/pull/1303#discussion_r2032167195
##########
plugins/spark/v3.5/build.gradle.kts:
##########
@@ -95,7 +114,10 @@ tasks.register<ShadowJar>("createPolarisSparkJar") {
// Optimization: Minimize the JAR (remove unused classes from dependencies)
// The iceberg-spark-runtime plugin is always packaged along with our
polaris-spark plugin,
// therefore excluded from the optimization.
- minimize {
exclude(dependency("org.apache.iceberg:iceberg-spark-runtime-*.*")) }
+ minimize {
+ exclude(dependency("org.apache.iceberg:iceberg-spark-runtime-*.*"))
Review Comment:
There are couple of reason for now:
1) the minimize optimization doesn't work for reflections, and iceberg
runtime uses a lot of reflections today.
2) the client side is compiled with particular version today, mix iceberg
library with a different version may have some unknown behavior. For the first
version, I plan to ship it with a particular version, and then we can work on
better separation of the libraries in the future release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
