flyrain commented on code in PR #1330:
URL: https://github.com/apache/polaris/pull/1330#discussion_r2032174067


##########
build-logic/src/main/kotlin/publishing/configurePom.kt:
##########
@@ -103,7 +103,10 @@ internal fun configurePom(project: Project, 
mavenPublication: MavenPublication,
               connection.set("scm:git:$codeRepo")
               developerConnection.set("scm:git:$codeRepo")
               url.set("$codeRepo/tree/main")
-              tag.set("main")
+              val version = project.version.toString()
+              if (!version.endsWith("-SNAPSHOT")) {
+                tag.set("apache-polaris-$version")

Review Comment:
   Q: Does it work automatically when we retag with the same version(e.g., 
`1.1.0`)? Or we need to remove the tag first, and run the command `mvn 
release:prepare` to retag it?
   
   Retag could be useful when we have multiple release candidates.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to