collado-mike commented on PR #1295: URL: https://github.com/apache/polaris/pull/1295#issuecomment-2799049536
> In Spark's ConfigBuilder, which I loosely modeled PolarisConfiguration off of, optional configs are quite common and seeing get everywhere is pretty common as well. However that's scala where Option is a much more common and ergonomic construct. Yeah, Spark has a _lot_ more optional config options and Option is idiomatic and expectation Scala. I agree that Optionals are safer than null. I can imagine some cases where we'd want to see if the value is present (e.g., some metrics reporting service or a lineage api that we could publish information to, if configured by the user). But TBH, rather than cluttering up every config lookup, I'd probably advocate for adding a specific lookup API that returned Optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
