collado-mike commented on code in PR #1353:
URL: https://github.com/apache/polaris/pull/1353#discussion_r2045050829
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PrincipalRoleEntity.java:
##########
@@ -38,19 +38,19 @@ public static PrincipalRoleEntity of(PolarisBaseEntity
sourceEntity) {
public static PrincipalRoleEntity fromPrincipalRole(PrincipalRole
principalRole) {
return new Builder()
.setName(principalRole.getName())
+ .setFederated(principalRole.getFederated())
.setProperties(principalRole.getProperties())
.build();
}
public PrincipalRole asPrincipalRole() {
- PrincipalRole principalRole =
- new PrincipalRole(
- getName(),
- getPropertiesAsMap(),
- getCreateTimestamp(),
- getLastUpdateTimestamp(),
- getEntityVersion());
- return principalRole;
+ return new PrincipalRole(
+ getName(),
+ PolarisEntity.isFederated(this),
Review Comment:
Normally, I'd agree, but here I am trying to stick to the convention of
keeping the entity-specific args at the front and the general,
id/created/updated-at timestamps at the end. That's the convention that every
entity type follows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
