dimas-b commented on code in PR #1371: URL: https://github.com/apache/polaris/pull/1371#discussion_r2048020287
########## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java: ########## @@ -45,14 +46,15 @@ public class JdbcMetaStoreManagerFactory extends LocalPolarisMetaStoreManagerFac // TODO: Pending discussion of if we should have one Database per realm or 1 schema per realm // or realm should be a primary key on all the tables. - @Inject DataSource dataSource; + @Inject Instance<DataSource> dataSource; Review Comment: Noted. In this case, I'd say we have to refactor this and have a "producer" in quarkus-specific modules to allow clean injection int the jdbc module (i.e. quarkus-specific code can use `Instance`, but believe is it best avoided here). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
