singhpk234 commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2057341514
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -106,12 +107,12 @@ private void initializeForRealm(
}
private DatasourceOperations getDatasourceOperations(boolean isBootstrap) {
- DatasourceOperations databaseOperations = new
DatasourceOperations(dataSource);
+ DatasourceOperations databaseOperations = new
DatasourceOperations(dataSource.get());
if (isBootstrap) {
// TODO: see if we need to take script from Quarkus or can we just
// use the script committed in the repo.
try {
-
databaseOperations.executeScript("scripts/postgres/schema-v1-postgres.sql");
+ databaseOperations.executeScript("postgres/schema-v1-postgresql.sql");
Review Comment:
I see so essentially type wil indicate the script directory ? and then all
the scripts will have same name like for ex schema-v1.sql
```
- h2
- schema-v1.sql
- postgres
- schema-v1.sql
```
so the config we get lets say db type
script will be `{type}/schema-v1.sql` ?
sounds good to me,
cc @flyrain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
