dimas-b commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2059262049
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -106,12 +107,12 @@ private void initializeForRealm(
}
private DatasourceOperations getDatasourceOperations(boolean isBootstrap) {
- DatasourceOperations databaseOperations = new
DatasourceOperations(dataSource);
+ DatasourceOperations databaseOperations = new
DatasourceOperations(dataSource.get());
if (isBootstrap) {
// TODO: see if we need to take script from Quarkus or can we just
// use the script committed in the repo.
try {
-
databaseOperations.executeScript("scripts/postgres/schema-v1-postgres.sql");
+ databaseOperations.executeScript("postgres/schema-v1-postgresql.sql");
Review Comment:
I'd prefer to autodetect like
[this](https://github.com/projectnessie/nessie/blob/de0576ef253df95b03b55f25bf0a50e1b6a3b1f3/versioned/storage/jdbc/src/main/java/org/projectnessie/versioned/storage/jdbc/DatabaseSpecifics.java#L66)
Then each enum value would have a compile-time parameter pointing to the
init script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
