adutra commented on code in PR #1309:
URL: https://github.com/apache/polaris/pull/1309#discussion_r2060192690
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisApplicationIntegrationTest.java:
##########
@@ -371,8 +371,11 @@ public void testIcebergCreateTablesInExternalCatalog()
throws IOException {
TableIdentifier.of(ns, "the_table"),
new Schema(
List.of(
- Types.NestedField.of(
- 1, false, "theField",
Types.StringType.get()))))
+ Types.NestedField.builder()
+ .withId(1)
+ .withName("theField")
+ .ofType(Types.StringType.get())
+ .build())))
Review Comment:
`asRequired()` you mean? That's the default, so I indeed omitted that. Do
you prefer to explicitly call `asRequired()` each time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
