flyrain commented on code in PR #1464:
URL: https://github.com/apache/polaris/pull/1464#discussion_r2060816320
##########
regtests/t_spark_sql/ref/spark_sql_azure_blob.sh.ref:
##########
@@ -1,4 +1,4 @@
-{"defaults":{"default-base-location":"abfss://polaris-contai...@polarisadls.blob.core.windows.net/polaris-test/spark_sql_blob_catalog/"},"overrides":{"prefix":"spark_sql_azure_blob_catalog"},"endpoints":["GET
/v1/{prefix}/namespaces","GET /v1/{prefix}/namespaces/{namespace}","POST
/v1/{prefix}/namespaces","POST
/v1/{prefix}/namespaces/{namespace}/properties","DELETE
/v1/{prefix}/namespaces/{namespace}","GET
/v1/{prefix}/namespaces/{namespace}/tables","GET
/v1/{prefix}/namespaces/{namespace}/tables/{table}","POST
/v1/{prefix}/namespaces/{namespace}/tables","POST
/v1/{prefix}/namespaces/{namespace}/tables/{table}","DELETE
/v1/{prefix}/namespaces/{namespace}/tables/{table}","POST
/v1/{prefix}/tables/rename","POST
/v1/{prefix}/namespaces/{namespace}/register","POST
/v1/{prefix}/namespaces/{namespace}/tables/{table}/metrics","GET
/v1/{prefix}/namespaces/{namespace}/views","GET
/v1/{prefix}/namespaces/{namespace}/views/{view}","POST
/v1/{prefix}/namespaces/{namespace}/views","POST /v1/{pr
efix}/namespaces/{namespace}/views/{view}","DELETE
/v1/{prefix}/namespaces/{namespace}/views/{view}","POST
/v1/{prefix}/views/rename","POST /v1/{prefix}/transactions/commit"]}
+{"defaults":{"default-base-location":"abfss://polaris-contai...@polarisadls.blob.core.windows.net/polaris-test/spark_sql_blob_catalog/"},"overrides":{"prefix":"spark_sql_azure_blob_catalog"},"endpoints":["GET
/v1/{prefix}/namespaces","GET /v1/{prefix}/namespaces/{namespace}","HEAD
/v1/{prefix}/namespaces/{namespace}","POST /v1/{prefix}/namespaces","POST
/v1/{prefix}/namespaces/{namespace}/properties","DELETE
/v1/{prefix}/namespaces/{namespace}","GET
/v1/{prefix}/namespaces/{namespace}/tables","GET
/v1/{prefix}/namespaces/{namespace}/tables/{table}","HEAD
/v1/{prefix}/namespaces/{namespace}/tables/{table}","POST
/v1/{prefix}/namespaces/{namespace}/tables","POST
/v1/{prefix}/namespaces/{namespace}/tables/{table}","DELETE
/v1/{prefix}/namespaces/{namespace}/tables/{table}","POST
/v1/{prefix}/tables/rename","POST
/v1/{prefix}/namespaces/{namespace}/register","POST
/v1/{prefix}/namespaces/{namespace}/tables/{table}/metrics","POST
/v1/{prefix}/transactions/commit","GET /v1/{prefix}/namesp
aces/{namespace}/views","GET
/v1/{prefix}/namespaces/{namespace}/views/{view}","HEAD
/v1/{prefix}/namespaces/{namespace}/views/{view}","POST
/v1/{prefix}/namespaces/{namespace}/views","POST
/v1/{prefix}/namespaces/{namespace}/views/{view}","DELETE
/v1/{prefix}/namespaces/{namespace}/views/{view}","POST
/v1/{prefix}/views/rename","POST /v1/{prefix}/transactions/commit","GET
polaris/v1/{prefix}/namespaces/{namespace}/generic-tables","POST
polaris/v1/{prefix}/namespaces/{namespace}/generic-tables","DELETE
polaris/v1/{prefix}/namespaces/{namespace}/generic-tables/{generic-table}","GET
polaris/v1/{prefix}/namespaces/{namespace}/generic-tables/{generic-table}","GET
/polaris/v1/{prefix}/namespaces/{namespace}/policies","POST
/polaris/v1/{prefix}/namespaces/{namespace}/policies","GET
/polaris/v1/{prefix}/namespaces/{namespace}/policies/{policy-name}","PUT
/polaris/v1/{prefix}/namespaces/{namespace}/policies/{policy-name}","DELETE
/polaris/v1/{prefix}/namespaces/{namespace}/policies/{policy-
name}","PUT
/polaris/v1/{prefix}/namespaces/{namespace}/policies/{policy-name}/mappings","POST
/polaris/v1/{prefix}/namespaces/{namespace}/policies/{policy-name}/mappings","GET
/polaris/v1/{prefix}/applicable-policies"]}
Review Comment:
The default value for generic table is false, wouldn't that be an issue?
```
public static final FeatureConfiguration<Boolean> ENABLE_GENERIC_TABLES =
PolarisConfiguration.<Boolean>builder()
.key("ENABLE_GENERIC_TABLES")
.description("If true, the generic-tables endpoints are enabled")
.defaultValue(false)
.buildFeatureConfiguration();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
