pingtimeout commented on PR #22: URL: https://github.com/apache/polaris-tools/pull/22#issuecomment-2848665243
I found it weird that you linked the Gatling mailing list with the solution `.disableCaching` and suspected there was just one commit not pushed :-). No worries. Note that I think the header override is misleading you. Like, you are seeing it in access logs, so it makes it look like the override is necessary, but the override is what creates the header itself. If you run a workload with `.disableCaching` and just that, you will see that even though the server returns an Etag, Gatling does not send it in subsequent requests. There is no need to override it. See the output below with `TRACE` logging to see all queries. Even though the server returns the Etag twice, the `If-None-Match` header is not sent in the second request for table `T_0`. ``` 16:57:49.846 [TRACE] i.g.h.e.r.DefaultStatsProcessor - >>>>>>>>>>>>>>>>>>>>>>>>>> Request: Fetch Table: OK ... HTTP request: GET http://localhost:8181/api/catalog/v1/C_0/namespaces/NS_0%1FNS_1%1FNS_3%1FNS_7%1FNS_15/tables/T_0 headers: accept: application/json content-type: application/json Authorization: Bearer ... host: localhost:8181 ========================= HTTP response: version: HTTP/1.1 status: 200 OK headers: Content-Type: application/json;charset=UTF-8 content-length: 1618 ETag: W/"1aa1ed45b04ff32ecc20df4e9d7953a7cd71146c111fa6c8d8e3a9c147524f11" [...] 16:57:50.455 [TRACE] i.g.h.e.r.DefaultStatsProcessor - >>>>>>>>>>>>>>>>>>>>>>>>>> Request: Fetch Table: OK ... HTTP request: GET http://localhost:8181/api/catalog/v1/C_0/namespaces/NS_0%1FNS_1%1FNS_3%1FNS_7%1FNS_15/tables/T_0 headers: accept: application/json content-type: application/json Authorization: Bearer ... host: localhost:8181 ========================= HTTP response: version: HTTP/1.1 status: 200 OK headers: Content-Type: application/json;charset=UTF-8 content-length: 1618 ETag: W/"1aa1ed45b04ff32ecc20df4e9d7953a7cd71146c111fa6c8d8e3a9c147524f11" ``` So I think the header override is unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
