eric-maynard commented on code in PR #1528:
URL: https://github.com/apache/polaris/pull/1528#discussion_r2078361797
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##########
@@ -408,4 +414,7 @@ boolean hasChildren(
default BasePersistence detach() {
return this;
}
+
+ @Nonnull
+ PageToken.PageTokenBuilder<?> pageTokenBuilder();
Review Comment:
The intent here is that different metastores could have different PageToken
implementations that they need to use. For example, it seems like EclipseLink
may just not support pagination, which is fine.
Practically, we need a way for persistence to be able to say "Ok, I fetched
the first N results, here's a page token that will give you the next page". The
builder which constructs that page token varies by persistence implementation.
But if a different code structure would work better here I'm very open to it.
Maybe we need something more like a factory? I wanted to avoid creating to many
unnecessary types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
