dimas-b commented on code in PR #1555:
URL: https://github.com/apache/polaris/pull/1555#discussion_r2107510570
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##########
@@ -413,4 +415,7 @@ boolean hasChildren(
default BasePersistence detach() {
return this;
}
+
+ /** Construct a {@link PageToken} from a {@link PageRequest} */
+ PageToken buildPageToken(PageRequest pageRequest);
Review Comment:
I mean the building of the page token does not have to be requested via
`BasePersistence` now. It is performed by impl-specific code as part of
building the response `Page`.
Since we do not have to add an interface method, why add? Let's keep the
interface as lean as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
