dimas-b commented on code in PR #1817:
URL: https://github.com/apache/polaris/pull/1817#discussion_r2132162610
##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/task/QuarkusTaskExecutorImpl.java:
##########
@@ -49,9 +52,11 @@ public QuarkusTaskExecutorImpl(
MetaStoreManagerFactory metaStoreManagerFactory,
TaskFileIOSupplier fileIOSupplier,
Tracer tracer,
- PolarisEventListener polarisEventListener) {
+ PolarisEventListener polarisEventListener,
Review Comment:
Re: test coverage : when my new code had `checkState` assertions, it caused
CI failures in the tests I had to modify. Unfortunately, after rebasing request
context stuff is no longer injected into the default config impl., so it cannot
perform those checks :shrug: I'll address this if the community decides to go
ahead with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
