snazy commented on code in PR #1831:
URL: https://github.com/apache/polaris/pull/1831#discussion_r2140732691
##########
gradle/libs.versions.toml:
##########
@@ -20,9 +20,9 @@
[versions]
hadoop = "3.4.1"
iceberg = "1.9.0" # Ensure to update the iceberg version in regtests to keep
regtests up-to-date
-quarkus = "3.21.4"
immutables = "2.10.1"
picocli = "4.7.7"
+quarkus = "3.21.4"
Review Comment:
unrelated?
##########
codestyle/errorprone-rules.properties:
##########
@@ -294,3 +294,6 @@ UnnecessaryBoxedVariable=ERROR
UseEnumSwitch=ERROR
# Prefer using a switch instead of a chained if-else for enums
+
+WildcardImport=ERROR
+# Wildcard imports, static or otherwise, should not be used
Review Comment:
Super-nit: add a trailing LF
##########
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java:
##########
@@ -112,7 +112,7 @@ public CaseInsensitiveStringMap
validateAndResolveCatalogOptions(
* Initialize REST Catalog for Iceberg and Polaris, this is the only catalog
type supported by
* Polaris at this moment.
*/
- private void initRESTCatalog(String name, CaseInsensitiveStringMap options) {
+ private void initRestCatalog(String name, CaseInsensitiveStringMap options) {
Review Comment:
unrelated to the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
