gh-yzou commented on code in PR #1857:
URL: https://github.com/apache/polaris/pull/1857#discussion_r2143427739
##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -179,3 +179,5 @@ tasks.named<ShadowJar>("shadowJar") {
relocate("com.fasterxml", "org.apache.polaris.shaded.com.fasterxml")
relocate("org.apache.avro", "org.apache.polaris.shaded.org.apache.avro")
}
+
+tasks.withType(Jar::class).named("sourcesJar") { dependsOn("shadowJar") }
Review Comment:
This is to make sure when we run both assemble and build, the shadow Jar job
is also run. I can add a depends on for assemble and build independently, but
seems adding it for sourceJar can make sure both works. I can add a comment
there to be more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
