dimas-b commented on code in PR #1933:
URL: https://github.com/apache/polaris/pull/1933#discussion_r2165235413
##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -45,17 +45,7 @@ val scalaLibraryVersion =
dependencies {
// TODO: extract a polaris-rest module as a thin layer for
// client to depends on.
- implementation(project(":polaris-core")) {
- exclude("org.apache.iceberg", "*")
- exclude("com.azure", "*")
- exclude("software.amazon.awssdk", "*")
- exclude("com.google.cloud", "*")
- exclude("io.airlift", "*")
- exclude("io.smallrye", "*")
- exclude("io.smallrye.common", "*")
- exclude("io.swagger", "*")
- exclude("org.apache.commons", "*")
- }
+ implementation(project(":polaris-core")) { isTransitive = false }
Review Comment:
As far as I understand, the only thing the Spark Client uses from core is
`PolarisResourcePaths` + `PolarisEndpoints`.
Depending on `polaris-core` without using any "core" functionality looks
awkward to me. If the intention is to reuse those two classes, I believe it
would be preferable to move them to an API module. WDYT (for followup)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
