eric-maynard commented on code in PR #1938:
URL: https://github.com/apache/polaris/pull/1938#discussion_r2167135430
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/entity/ListEntitiesResult.java:
##########
@@ -46,43 +41,26 @@ public static ListEntitiesResult
fromPage(Page<EntityNameLookupRecord> page) {
* @param errorCode error code, cannot be SUCCESS
* @param extraInformation extra information
*/
- public ListEntitiesResult(
- @Nonnull ReturnStatus errorCode,
- @Nullable String extraInformation,
- @Nonnull Optional<PageToken> pageTokenOpt) {
+ public ListEntitiesResult(@Nonnull ReturnStatus errorCode, @Nullable String
extraInformation) {
super(errorCode, extraInformation);
this.entities = null;
- this.pageTokenOpt = pageTokenOpt;
}
/**
* Constructor for success
*
* @param entities list of entities being returned, implies success
*/
- public ListEntitiesResult(
- @Nonnull List<EntityNameLookupRecord> entities, @Nonnull
Optional<PageToken> pageTokenOpt) {
+ public ListEntitiesResult(Page<EntityNameLookupRecord> entities) {
super(ReturnStatus.SUCCESS);
this.entities = entities;
- this.pageTokenOpt = pageTokenOpt;
}
- @JsonCreator
- private ListEntitiesResult(
Review Comment:
ditto the comment on wire-compatibility with previous versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
